Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Yadro (Tatlin FCVolume) storage backend implementation to Sunbeam and integrates it into the existing backend test suite/fixtures so it is discovered and validated alongside the other backends.
Changes:
- Introduce
YadroBackendandYadroConfig(with protocol validation via an enum). - Add unit tests for the Yadro backend and config validation.
- Update shared backend test fixtures and common “all backends” tests to include Yadro.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/yadro/backend.py |
Implements the Yadro storage backend and its Pydantic config model. |
sunbeam-python/sunbeam/storage/backends/yadro/__init__.py |
Declares the Yadro backend package. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Adds a yadro_backend fixture and includes Yadro in the parametrized backend fixture. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Extends shared backend uniqueness/expectation tests to cover Yadro. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_yadro.py |
Adds backend-specific unit tests and basic config validation checks for Yadro. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new “yadro” storage backend and wires it into the unit-test matrix to validate backend identity and config validation behavior.
Changes:
- Introduces
YadroBackend+YadroConfigimplementation. - Adds
yadro_backendpytest fixture and includes it in common backend uniqueness/expectation tests. - Adds new unit tests for the Yadro backend and protocol validation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/yadro/backend.py | New Yadro backend implementation and pydantic config model. |
| sunbeam-python/sunbeam/storage/backends/yadro/init.py | New package initializer for the Yadro backend module. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds a yadro_backend fixture and includes Yadro in any_backend. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Extends shared tests to cover Yadro type/charm-name uniqueness and expectations. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_yadro.py | New tests covering Yadro backend identity and basic config validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-yadro-charm
branch
from
147a12c to
b62d747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984539